Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requirements when updating check #4895

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Update requirements when updating check #4895

merged 2 commits into from
Oct 29, 2019

Conversation

therve
Copy link
Contributor

@therve therve commented Oct 28, 2019

We need to pass the requirements explicitly when updating a check to
its development version.

@therve
Update requirements when updating check
19f0d99 
We need to pass the requirements explicitly when updating a check to
its development version.
@therve therve requested a review from a team as a code owner October 28, 2019 13:16
hithwen
hithwen previously approved these changes Oct 28, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0620913). Click here to learn what that means.
The diff coverage is n/a.

AlexandreYang
AlexandreYang reviewed Oct 28, 2019
View reviewed changes
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment.

datadog_checks_dev/datadog_checks/dev/tooling/e2e/docker.py Outdated Show resolved Hide resolved
@therve therve merged commit 9372ae8 into master Oct 29, 2019
@therve therve deleted the therve/dev-requirements branch October 29, 2019 09:07
@ofek ofek mentioned this pull request Oct 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang left review comments

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@therve @hithwen @AlexandreYang