Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default version from env test #4718

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Remove default version from env test #4718

merged 1 commit into from
Oct 9, 2019

Conversation

therve
Copy link
Contributor

@therve therve commented Oct 9, 2019 •
edited
Loading

We get the version properly in start, no need to duplicate the value,
and it breaks default detection.

@therve
Remove default version from env test
79c4203 
We get the version properly in start, no need to duplicate the value,
and it breaks default detection.
@therve therve requested a review from a team as a code owner October 9, 2019 09:17
@codecov
Copy link

codecov bot commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #4718 into master will decrease coverage by 17.32%.
The diff coverage is n/a.

Impacted Files Coverage Δ
vertica/tests/metrics.py
riakcs/datadog_checks/riakcs/riakcs.py
oracle/tests/test_oracle.py
twistlock/datadog_checks/twistlock/twistlock.py
linkerd/datadog_checks/linkerd/linkerd.py
...oller/datadog_checks/openstack_controller/utils.py
istio/tests/test_e2e.py
gitlab_runner/tests/test_integration.py
...hecks/openstack_controller/openstack_controller.py
...ent_log/datadog_checks/win32_event_log/__init__.py
... and 735 more

@therve therve merged commit 61ceeb6 into master Oct 9, 2019
@therve therve deleted the therve/docker-default-version branch October 9, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therve @AlexandreYang