Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SQL Server e2e tests #4427

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Add SQL Server e2e tests #4427

merged 1 commit into from
Aug 26, 2019

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Aug 24, 2019

Additional Notes

Also made test setup work on Windows & macOS

@ofek ofek requested a review from a team as a code owner August 24, 2019 12:44
@codecov
Copy link

codecov bot commented Aug 24, 2019 •
edited
Loading

Codecov Report

Merging #4427 into master will decrease coverage by 10.76%.
The diff coverage is 76.66%.

Impacted Files Coverage Δ
sqlserver/tests/conftest.py 84% <100%> (+28%) ⬆️
sqlserver/tests/utils.py 100% <100%> (ø)
sqlserver/tests/test_sqlserver.py 88% <57.14%> (+37.25%) ⬆️
sqlserver/tests/common.py 91.3% <90%> (+1.83%) ⬆️
windows_service/tests/common.py
disk/datadog_checks/disk/__init__.py
...checks_dev/tests/plugin/test_environment_runner.py
datadog_checks_base/tests/test_similar.py
win32_event_log/tests/test_check.py
...service/datadog_checks/windows_service/__init__.py
... and 162 more

ChristineTChen
ChristineTChen approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofek ofek merged commit 7f66b44 into master Aug 26, 2019
@ofek ofek deleted the ofek/s branch August 26, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/sqlserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @ChristineTChen