Support Python 3 when calling pip for extra E2E start up commands #4213
Conversation
| @@ -79,6 +79,9 @@ def agent_command(self): | |||
| return get_agent_exe(self.agent_version, platform=self.platform) | |||
|
|
|||
| def exec_command(self, command, **kwargs): | |||
| if command.startswith('pip '): | |||
| command = command.replace('pip ', get_pip_exe(self.python_version, self.platform), 1) | |||
There was a problem hiding this comment.
We should fix get_pip_exe for MAC, otherwise it won't work for the majority of us.
There was a problem hiding this comment.
This exec_command is to run commands in docker not on the local machine
There was a problem hiding this comment.
Well no this is local environment support.
There was a problem hiding this comment.
Oh, sorry, there is another exec_command in docker.py
There was a problem hiding this comment.
Yeah, for local environment should it use the tox pip rather than the agent pip? In that case its going to be already the right version or at most replace it with python -m pip
| @@ -79,6 +79,9 @@ def exec_command(self, command, **kwargs): | |||
| if kwargs.pop('interactive', False): | |||
| cmd += ' -it' | |||
|
|
|||
| if command.startswith('pip '): | |||
| command = command.replace('pip ', get_pip_exe(self.python_version), 1) | |||
There was a problem hiding this comment.
how is this working? you cannot replace a string with a list
There was a problem hiding this comment.
command is a string, see line 86
There was a problem hiding this comment.
but get_pip_exe(self.python_version) returns an array
Motivation
A few integrations, like ibm_db2