Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple Python versions for E2E #4075

Merged
merged 3 commits into from
Jul 9, 2019
Merged

Support multiple Python versions for E2E #4075

merged 3 commits into from
Jul 9, 2019

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jul 9, 2019

No description provided.

@ofek ofek requested a review from a team as a code owner July 9, 2019 05:21
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #4075 into master will decrease coverage by 8.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4075      +/-   ##
==========================================
- Coverage    86.9%   78.17%   -8.73%     
==========================================
  Files         747       34     -713     
  Lines       38035     1306   -36729     
  Branches     4375      134    -4241     
==========================================
- Hits        33053     1021   -32032     
+ Misses       3823      254    -3569     
+ Partials     1159       31    -1128

therve
therve reviewed Jul 9, 2019
View reviewed changes
Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the version from the tox env, if you're able to detect it? Is there a usecase where we'd like them to differ?

AlexandreYang
AlexandreYang requested changes Jul 9, 2019
View reviewed changes
Copy link
Member

@AlexandreYang AlexandreYang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just few minor and style comments.

datadog_checks_dev/datadog_checks/dev/tooling/commands/env/start.py Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/commands/env/start.py Outdated Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/commands/env/test.py Outdated Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/e2e/docker.py Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/testing.py Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/testing.py Outdated Show resolved Hide resolved
@ofek
Copy link
Contributor Author

ofek commented Jul 9, 2019

For posterity:

Although we have auto-detection of tox env Python versions, we'll keep the -py/--python so users aren't required to have more than one Python available.

@ofek @AlexandreYang
Apply suggestions from code review
a25364e 
Co-Authored-By: Alexandre YANG <49917914+AlexandreYang@users.noreply.github.com>
@ofek ofek merged commit b13cef9 into master Jul 9, 2019
@ofek ofek deleted the ofek/py3 branch July 9, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang approved these changes

@therve therve therve approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @therve @AlexandreYang