Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log section #4014

Merged
merged 6 commits into from
Jul 9, 2019
Merged

Add log section #4014

merged 6 commits into from
Jul 9, 2019

Conversation

FlorianVeaux
Copy link
Member

@FlorianVeaux FlorianVeaux commented Jul 1, 2019

No description provided.

@FlorianVeaux FlorianVeaux force-pushed the florianveaux/add_log_marathon branch from fb17a55 to 8c31ef1 Compare July 1, 2019 09:47
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Just a comment/discussion about logback.

marathon/datadog_checks/marathon/data/conf.yaml.example Outdated Show resolved Hide resolved
marathon/README.md Outdated Show resolved Hide resolved
Co-Authored-By: Alexandre YANG <49917914+AlexandreYang@users.noreply.github.com>
therve
therve previously approved these changes Jul 4, 2019
marathon/README.md Outdated Show resolved Hide resolved
Co-Authored-By: Julia <611228+hithwen@users.noreply.github.com>
AlexandreYang
AlexandreYang previously approved these changes Jul 5, 2019
marathon/README.md Outdated Show resolved Hide resolved
l0k0ms
l0k0ms previously approved these changes Jul 9, 2019
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one small nits but otherwise it's g2g !

Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g2g 4 docs

@FlorianVeaux FlorianVeaux merged commit 4cd786a into master Jul 9, 2019
@FlorianVeaux FlorianVeaux deleted the florianveaux/add_log_marathon branch July 9, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants