Fix event payload so the check name is parsed correctly #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3979 +/- ##
===========================================
+ Coverage 79.43% 89.97% +10.53%
===========================================
Files 158 7 -151
Lines 8059 439 -7620
Branches 975 54 -921
===========================================
- Hits 6402 395 -6007
+ Misses 1429 30 -1399
+ Partials 228 14 -214 |
|
I'm looking at the server side processing, and I don't see how it can make a difference. Can you explain what it's supposed to fix? Thanks. |
6 tasks
|
Discussed offline, we're testing this |
therve
approved these changes
Jun 27, 2019
ofek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
event_typeis not a parsed field. Matches behavior here:integrations-core/nagios/datadog_checks/nagios/nagios.py
Line 368 in ef49b25