Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] update doc with new manifest.json output #3969

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Conversation

phrawzty
Copy link
Contributor

What does this PR do?

This updates the "new check docs" (which should probably be renamed but…) with a more recent manifest.json sample.

I also replaced an asterisk with a slightly different asterisk because it was destroying IDE highlighting. :P

Motivation

Keeping things up to date (and highlighting).

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@ofek ofek merged commit ef49b25 into master Jun 25, 2019
@ofek ofek deleted the update_new_intg_docs branch June 25, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants