Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hive metadatas #3851

Merged
merged 3 commits into from
Jun 6, 2019
Merged

Fix Hive metadatas #3851

merged 3 commits into from
Jun 6, 2019

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Jun 3, 2019

What does this PR do?

Fix metadatas to run the jenkins job

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@coignetp coignetp requested a review from a team as a code owner June 3, 2019 13:17
zippolyte
zippolyte previously approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hithwen
hithwen reviewed Jun 3, 2019
View reviewed changes
hive/datadog_checks/hive/data/metrics.yaml
alias: hive.server.memory.non-heap.init
metric_type: gauge
- include:
bean: metrics:name=memory.non-heap.usage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usage one got deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was removed from config.default.yaml and metadata.csv, but was still in metrics.yaml

AlexandreYang
AlexandreYang reviewed Jun 3, 2019
View reviewed changes
Copy link
Member

@AlexandreYang AlexandreYang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for using 10 seconds as interval instead of leaving it empty and use the default interval ?

(not related to this PR itself)

@coignetp coignetp merged commit 586287a into master Jun 6, 2019
@AlexandreYang AlexandreYang mentioned this pull request Jun 6, 2019
Merged
6 tasks
@l0k0ms l0k0ms deleted the paul/hive-metricnames branch June 19, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang left review comments

@hithwen hithwen hithwen left review comments

@therve therve therve approved these changes

@zippolyte zippolyte zippolyte left review comments

Assignees
No one assigned
Labels
integration/hive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coignetp @therve @hithwen @zippolyte @AlexandreYang