Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra type for manifest validation #3662

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Add extra type for manifest validation #3662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 4 additions & 24 deletions datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,36 +314,16 @@ def manifest(fix, include_extras):
display_queue.append((echo_failure, ' required non-null sequence: categories'))

# type
correct_integration_type = 'check'
correct_integration_types = ['check', 'crawler']
integration_type = decoded.get('type')
if not integration_type or not isinstance(integration_type, string_types):
file_failures += 1
output = ' required non-null string: type'

if fix:
decoded['type'] = correct_integration_type

display_queue.append((echo_warning, output))
display_queue.append((echo_success, ' new `type`: {}'.format(correct_integration_type)))

file_failures -= 1
file_fixed = True
else:
display_queue.append((echo_failure, output))
elif integration_type != correct_integration_type:
display_queue.append((echo_failure, output))
elif integration_type not in correct_integration_types:
file_failures += 1
output = ' invalid `type`: {}'.format(integration_type)

if fix:
decoded['type'] = correct_integration_type

display_queue.append((echo_warning, output))
display_queue.append((echo_success, ' new `type`: {}'.format(correct_integration_type)))

file_failures -= 1
file_fixed = True
else:
display_queue.append((echo_failure, output))
display_queue.append((echo_failure, output))

# is_public
correct_is_public = True
Expand Down