Add util to load jmx metric configs #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3162 +/- ##
==========================================
- Coverage 84.61% 81.18% -3.44%
==========================================
Files 677 30 -647
Lines 36619 999 -35620
Branches 4319 85 -4234
==========================================
- Hits 30984 811 -30173
+ Misses 4373 158 -4215
+ Partials 1262 30 -1232 |
nmuesch
reviewed
Feb 20, 2019
| @@ -182,6 +183,24 @@ def get_here(): | |||
| return get_parent_dir(inspect.currentframe().f_back.f_code.co_filename) | |||
|
|
|||
|
|
|||
| def load_jmx_config(): | |||
| root = get_parent_dir(inspect.currentframe().f_back.f_code.co_filename) | |||
There was a problem hiding this comment.
Could this use the new get_here method you made?
There was a problem hiding this comment.
No I think b/c that would get this location
nmuesch
reviewed
Feb 20, 2019
|
|
||
| new_root = os.path.dirname(root) | ||
| if new_root == root: | ||
| return {} |
There was a problem hiding this comment.
What do you think about raising an exception here? I think if you use this function and there is no metrics.yaml, that's a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support e2e for jmx checks soon
Note:
PyYAMLis now a test dep instead