Fix agent_changelog command #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
requested changes
Dec 21, 2018
| given file contents. We can assume lines are in the form: | ||
|
|
||
| active_directory==1.1.1; sys_platform == 'win32' | ||
| active-directory==1.1.1; sys_platform == 'win32' |
There was a problem hiding this comment.
datadog-active-directory
Codecov Report
@@ Coverage Diff @@
## master #2808 +/- ##
=========================================
- Coverage 84.88% 78.6% -6.28%
=========================================
Files 660 23 -637
Lines 37572 776 -36796
Branches 4504 80 -4424
=========================================
- Hits 31894 610 -31284
+ Misses 4363 138 -4225
+ Partials 1315 28 -1287 |
zippolyte
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
requirements-agent-release.txtfile we parse to generate the changelog has a weird git history and the generation command wasn't working correctly. This PR fixes the logic and adds a fair bunch of comments/docstrings so the process is better documented now.Review checklist
no-changeloglabel attached