Add instance level tags to Nagios Events #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2778 +/- ##
==========================================
+ Coverage 84.75% 89.83% +5.08%
==========================================
Files 657 7 -650
Lines 37463 433 -37030
Branches 4502 53 -4449
==========================================
- Hits 31750 389 -31361
+ Misses 4397 30 -4367
+ Partials 1316 14 -1302 |
gmmeyer
reviewed
Dec 17, 2018
| @@ -266,7 +267,8 @@ def compile_file_template(self, file_template): | |||
|
|
|||
|
|
|||
| class NagiosEventLogTailer(NagiosTailer): | |||
| def __init__(self, log_path, file_template, logger, hostname, event_func, gauge_func, freq, passive_checks=False): | |||
| def __init__(self, log_path, file_template, logger, hostname, tags, event_func, gauge_func, | |||
There was a problem hiding this comment.
wow this is a giant function signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the instance level tags to the Nagios events.
Also updates the test to assert that the tags are in each event that is processed.
Motivation
Customer request
Example of working Event with tags - https://cl.ly/43c9c4964795
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?