Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use dev version of base package for e2e #2689

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Dec 5, 2018

Motivation

capture0

@codecov-io
Copy link

Codecov Report

Merging #2689 into master will decrease coverage by 6.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
- Coverage   83.95%   77.21%   -6.75%     
==========================================
  Files         649       21     -628     
  Lines       36727      610   -36117     
  Branches     4462       65    -4397     
==========================================
- Hits        30835      471   -30364     
+ Misses       4572      113    -4459     
+ Partials     1320       26    -1294

Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofek ofek merged commit 60df089 into master Dec 5, 2018
@ofek ofek deleted the ofek/base branch December 5, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants