Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture metrics for ES scroll requests #2687

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

kevinconaway
Copy link
Contributor

What does this PR do?

Adds metrics for ES scroll requests that are exposed in indices.search:

    "indices": {
     ...
      "search": {
        "open_contexts": 4,
        "query_total": 795996720,
        "query_time_in_millis": 23224962799,
        "query_current": 7,
        "fetch_total": 89852997,
        "fetch_time_in_millis": 128959355,
        "fetch_current": 2,
        "scroll_total": 393249911,
        "scroll_time_in_millis": 40220899351103,
        "scroll_current": 1123,
        "suggest_total": 0,
        "suggest_time_in_millis": 0,
        "suggest_current": 0
      },
      ...

cc @DataDog/burrito

Motivation

To help differentiate between scroll requests and normal queries

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

@kevinconaway kevinconaway requested a review from a team as a code owner December 4, 2018 16:19
@codecov-io
Copy link

Codecov Report

Merging #2687 into master will increase coverage by 4.94%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
+ Coverage   83.92%   88.87%   +4.94%     
==========================================
  Files         649       11     -638     
  Lines       36471      602   -35869     
  Branches     4427       84    -4343     
==========================================
- Hits        30609      535   -30074     
+ Misses       4573       45    -4528     
+ Partials     1289       22    -1267

@kevinconaway kevinconaway merged commit cd036d8 into master Dec 5, 2018
@kevinconaway kevinconaway deleted the kevinconaway/add-es-scroll-metrics branch December 5, 2018 15:48
kevinconaway added a commit that referenced this pull request Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants