Increase gpg timeout to give time to developers to interact with Yubikeys #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
previously approved these changes
Nov 20, 2018
|
@zippolyte Thanks! Could you run a quick test on your machine? |
|
Yup I did, it's way better 💯 |
masci
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
- Coverage 83.85% 77.21% -6.65%
==========================================
Files 644 21 -623
Lines 36425 610 -35815
Branches 4426 65 -4361
==========================================
- Hits 30544 471 -30073
+ Misses 4563 113 -4450
+ Partials 1318 26 -1292 |
zippolyte
approved these changes
Nov 22, 2018
masci
deleted the
trishankatdatadog/increase-in-toto-gpg-timeout-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increase the timeout value for any GPG subprocess to run from in-toto.
Motivation
Developers find the current timeout value (3 seconds) to short to successfully find and enter their PINs.
Review checklist
no-changeloglabel attachedAdditional Notes
@zippolyte and @ofek should test this to make sure that the PR is satisfactory.