-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hyper-V integration #2607
Add Hyper-V integration #2607
Conversation
02b5f43
to
6b29ec5
Compare
97977bc
to
a4fcc47
Compare
95fd085
to
01c3798
Compare
When this is released, please make sure the integration logo is submitted to the documentation repo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
# This set is (mostly) from the Microsoft recommended counters to monitor Hyper-V: | ||
# https://docs.microsoft.com/en-us/windows-server/administration/performance-tuning/role/hyper-v-server | ||
# https://blogs.technet.microsoft.com/neales/2016/10/24/hyper-v-performance-cpu | ||
# TODO: Investigate additional recommended counters from: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this TODO still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it'll be ongoing based on customer feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why here and not on a tracking card?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link helps customers too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve, though you should address Greg's comment
Motivation
Customer requests