Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the initial release of integrations #2399

Merged
merged 2 commits into from
Oct 13, 2018
Merged

Support the initial release of integrations #2399

merged 2 commits into from
Oct 13, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Oct 13, 2018

Motivation

Need a way to automate 1.0.0 since there will be no existing tags to discover

@codecov-io
Copy link

Codecov Report

Merging #2399 into master will decrease coverage by 1.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2399      +/-   ##
==========================================
- Coverage   79.11%   77.57%   -1.54%     
==========================================
  Files         213       20     -193     
  Lines       14677      602   -14075     
  Branches     1596       65    -1531     
==========================================
- Hits        11611      467   -11144     
+ Misses       2645      109    -2536     
+ Partials      421       26     -395

Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about this pr

@@ -33,6 +33,14 @@
'ntp',
}

BETA_CHECKS = {
'datadog_checks_dev',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this beta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's changing a lot. 1.0.0 will happen after e2e is finished

@ofek ofek merged commit f510439 into master Oct 13, 2018
@ofek ofek deleted the ofek/new branch October 13, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants