Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit metrics with instance tags #2299

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Submit metrics with instance tags #2299

merged 1 commit into from
Oct 3, 2018

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Sep 25, 2018

What does this PR do?

Metrics going through the submit_as_gauge_and_monotonic_count method didn't inherit instance tags.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@xvello xvello requested a review from a team as a code owner September 25, 2018 16:27
@xvello xvello requested a review from a team September 25, 2018 16:27
@codecov-io
Copy link

Codecov Report

Merging #2299 into master will increase coverage by 13.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #2299       +/-   ##
==========================================
+ Coverage   85.67%   98.9%   +13.22%     
==========================================
  Files         188       4      -184     
  Lines       13428      91    -13337     
  Branches     1462       6     -1456     
==========================================
- Hits        11504      90    -11414     
+ Misses       1518       0     -1518     
+ Partials      406       1      -405

@xvello xvello merged commit b0ffc16 into master Oct 3, 2018
@xvello xvello deleted the xvello/kubedns-tag branch October 3, 2018 08:33
nmuesch pushed a commit that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants