Add configuration agent health event for Postgres #21347
+1,200
−832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
…530-add-agent-health-event-for-postgres-config-validation-2
eric-weaver
reviewed
Sep 17, 2025
| @@ -284,6 +289,7 @@ files: | |||
| example: true | |||
| - name: locks_idle_in_transaction | |||
| description: Configure collection of idle in transaction lock age metrics | |||
| hidden: true | |||
eric-weaver
reviewed
Sep 18, 2025
| for m in custom_metrics: | ||
| for param in required_parameters: | ||
| if param not in m: | ||
| raise ConfigurationError('Missing {} parameter in custom metric'.format(param)) |
There was a problem hiding this comment.
Can we be more descriptive into which custom metric has a missing parameter
eric-weaver
reviewed
Sep 18, 2025
| cap_mtype = mtype.upper() | ||
| if cap_mtype not in ('RATE', 'GAUGE', 'MONOTONIC'): | ||
| raise ConfigurationError( | ||
| 'Collector method {} is not known. Known methods are RATE, GAUGE, MONOTONIC'.format(cap_mtype) |
There was a problem hiding this comment.
Similarly here. I think it would be helpful to know which custom metric has an invalid type
eric-weaver
reviewed
Sep 18, 2025
|
|
||
| m['metrics'][ref][1] = METRIC_TYPES[cap_mtype] | ||
| except Exception as e: | ||
| raise Exception('Error processing custom metric `{}`: {}'.format(m, e)) |
There was a problem hiding this comment.
This is almost what I was looking for above, but it looks like m here is the full dict of metrics? This looks wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
InstanceConfgmodelMotivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged