Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Teleport metrics #19473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rosstimothy
Copy link

@rosstimothy rosstimothy commented Jan 23, 2025

What does this PR do?

In addition to adding the Teleport auth heartbeat_connections_received and teleport_roles metrics, this cleans up a few typos and updates Teleport image and tag used in the docker tests.

Motivation

Teleport customers are asking for the integration to be updated with all metrics exposed by Teleport: gravitational/teleport#50992.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (4cd13e8) to head (2b1872c).
Report is 9 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
teleport 98.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rosstimothy rosstimothy force-pushed the update_teleport_metrics branch 6 times, most recently from 8e64eae to de2d376 Compare January 24, 2025 05:10
In addition to adding the Teleport auth heartbeat_connections_received
and teleport_roles metrics, this cleans up a few typos and updates
Teleport image and tag used in the docker tests.
@rosstimothy rosstimothy force-pushed the update_teleport_metrics branch from de2d376 to 2b1872c Compare January 24, 2025 05:17
@rosstimothy rosstimothy marked this pull request as ready for review January 24, 2025 05:24
@rosstimothy rosstimothy requested review from a team as code owners January 24, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants