Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AI-4928] Add recommended monitor for octopus deploy #19442

Merged
merged 6 commits into from
Feb 3, 2025
Merged

[AI-4928] Add recommended monitor for octopus deploy #19442

merged 6 commits into from
Feb 3, 2025

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@sarah-witt sarah-witt mentioned this pull request Jan 21, 2025
Closed
3 tasks
@sarah-witt sarah-witt marked this pull request as ready for review January 21, 2025 15:21
@sarah-witt sarah-witt requested a review from a team January 21, 2025 15:21
@sarah-witt sarah-witt requested review from a team as code owners January 21, 2025 15:21
cswatt
cswatt previously approved these changes Jan 21, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (c1f78f4) to head (2d7247a).
Report is 14 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt added assets/no-deploy Prevents APW from deploying this PR in staging and removed assets/no-deploy Prevents APW from deploying this PR in staging labels Jan 22, 2025
@sarah-witt sarah-witt changed the title Add recommended monitor Add recommended monitor for octopus deploy Jan 29, 2025
@sarah-witt sarah-witt changed the title Add recommended monitor for octopus deploy [AI-4827] Add recommended monitor for octopus deploy Jan 29, 2025
@sarah-witt sarah-witt changed the title [AI-4827] Add recommended monitor for octopus deploy [AI-4928] Add recommended monitor for octopus deploy Jan 29, 2025
nubtron
nubtron previously approved these changes Jan 30, 2025
View reviewed changes
@sarah-witt sarah-witt requested a review from nubtron January 30, 2025 16:09
@sarah-witt sarah-witt added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit 405c681 Feb 3, 2025
31 checks passed
@sarah-witt sarah-witt deleted the sarah/octopus-recommended-monitor branch February 3, 2025 14:10
github-actions bot pushed a commit that referenced this pull request Feb 3, 2025
@github-merge-queue
[AI-4928] Add recommended monitor for octopus deploy (#19442)
1199ed5 
* Add recommended monitor

* update message

* update message and boundaries 405c681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nubtron nubtron nubtron approved these changes

@cswatt cswatt cswatt left review comments

Assignees
No one assigned
Labels
docs/approved ecosystems/review-requested product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarah-witt @nubtron @cswatt