Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide schemas_collection and write agent version #19030

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

edengorevoy
Copy link
Contributor

@edengorevoy edengorevoy commented Nov 11, 2024

What does this PR do?

Unhide the schemas_collection parameter as it's now available in the frontend.

Motivation

Link to feature release

We want this option exposed to customers now that there's a frontend for it.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (1609ed9) to head (8cc84a7).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 91.15% <ø> (+9.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@edengorevoy edengorevoy added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit 1583b10 Nov 11, 2024
46 of 47 checks passed
@edengorevoy edengorevoy deleted the eden.gorevoy/add-sqlserver-schema-and-agent branch November 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants