Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update langchain docs #18977

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Update langchain docs #18977

wants to merge 23 commits into from

Conversation

yahya-mouman
Copy link
Contributor

What does this PR do?

Updates langchain python and other languages integration docs

https://datadoghq.atlassian.net/browse/MLOB-1760

Motivation

https://docs.google.com/document/d/1mpR2xphp7d8squrxAXKwQv57qCqo342VbhEpVIgcP4o/edit?tab=t.0

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@yahya-mouman yahya-mouman marked this pull request as ready for review November 4, 2024 19:33
@yahya-mouman yahya-mouman requested review from a team as code owners November 4, 2024 19:33
@drichards-87 drichards-87 added the editorial review Waiting on a more in-depth review from a docs team editor label Nov 4, 2024
@drichards-87
Copy link
Contributor

Created Jira card for Docs Team editorial review.

steveny91
steveny91 previously approved these changes Nov 5, 2024
View reviewed changes
@hestonhoffman
Copy link
Contributor

👋 The build on this one fails ATM. I'm going to push a commit to fix that so I can review it

hestonhoffman
hestonhoffman reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback

langchain/README.md Outdated Show resolved Hide resolved
langchain/README.md Show resolved Hide resolved
langchain/README.md Outdated Show resolved Hide resolved
langchain/README.md Outdated Show resolved Hide resolved
langchain/README.md Show resolved Hide resolved
langchain/README.md Show resolved Hide resolved
langchain/README.md Show resolved Hide resolved
langchain/README.md Outdated Show resolved Hide resolved
langchain/README.md Outdated Show resolved Hide resolved
hestonhoffman and others added 3 commits November 6, 2024 16:11
@hestonhoffman
Update langchain/README.md
d691024
@yahya-mouman @hestonhoffman
Update langchain/README.md
16d0855 
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@yahya-mouman @hestonhoffman
Update langchain/README.md
2a0ac66 
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@yahya-mouman
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 13, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-13 18:16:27 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-13 18:16:29 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-13 18:57:55 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@yahya-mouman
Copy link
Contributor Author

/merge -c

@yahya-mouman
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 13, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-13 18:58:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-13 18:58:17 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-13 22:58:17 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@yahya-mouman
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 13, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-13 22:19:37 UTC ❌ MergeQueue

PR already in the queue with status waiting

@yahya-mouman
Copy link
Contributor Author

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Nov 13, 2024

Devflow running: /merge -c

View all feedbacks in Devflow UI.

2024-11-13 23:24:37 UTC ❌ Devflow: /merge -c

This merge request was already processed and can't be unqueued anymore.

To get help about command usage, write /merge --help

If you need support, contact us on Slack #devflow with those details!

@yahya-mouman
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 13, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-13 23:25:11 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-13 23:25:15 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-14 03:25:15 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janine-c janine-c janine-c approved these changes

@steveny91 steveny91 steveny91 approved these changes

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

@barieom barieom barieom left review comments

@hestonhoffman hestonhoffman hestonhoffman left review comments

Assignees
No one assigned
Labels
agent/approved changelog/no-changelog docs/approved documentation ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor integration/langchain mergequeue-status: removed product/review-requested team/agent-integrations team/documentation team/ml-observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yahya-mouman @drichards-87 @hestonhoffman @Kyle-Verhoog @steveny91 @barieom @janine-c