Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI-4493] DDS: Cisco Secure Web Appliance Integration v1.0.0 #18717

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

madhavpandya-crest
Copy link
Contributor

What does this PR do?

PR for a new integration Cisco Secure Web Appliance 1.0.0

Additional Notes

-- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository .
-- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current datadog behavior.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@neko-dd
Copy link
Contributor

neko-dd commented Sep 30, 2024

Created a ticket for the Docs team to review.

HadhemiDD
HadhemiDD previously approved these changes Nov 12, 2024
Comment on lines 3 to 4
# If for some reason id must be different than app_id, add the app_id in this field instead.
# If id and app_id already match, this field can be left blank.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We can probably remove this comment here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as Suggested.

sources:
- syslog.severity
- type: pipeline
name: Processing of l4tm logs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the . from the name here

Suggested change
name: Processing of l4tm logs.
name: Processing of l4tm logs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as Suggested.

name: Processing of l4tm logs.
enabled: true
filter:
query: "service:l4tm_logs "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra space here

Suggested change
query: "service:l4tm_logs "
query: "service:l4tm_logs"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as suggested.

98 10.10.10.10 TCP_DENIED_SSL/403 0 GET
https://www.virustotal.com:443/favicon.ico - NONE/- -
BLOCK_CUSTOMCAT_12-DefaultGroup-10.50.6.5-NONE-NONE-NONE-NONE-NONE
<"C_viru",-,-,"-",-,-,-,-,"-",-,-,-,"-",-,-,"-","-",-,-,"-",-,"-","-","-","-","-","-","-",0.00,0,-,"-","-",-,"-",-,-,"-","-",-,-,"-",-,->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pipeline seems to make the assumption that these 44 attributes will always arrive in this exact order in a comma-separated list, and that for example all logs from the Cisco Web Appliance will have a "YouTube URL" attribute at the end of the list. What is enforcing this format in the web appliance?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the integration supports the default (squid) log style for access logs and the same is also documented in the integration configuration steps.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitarajput-crest do you have a link to the cisco documentation that says this is the format?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obi11235 Here is the link to Cisco Secure Web Appliance documentation which provides the example log. Configuring the default log format option in the Cisco Secure Web Appliance Console will generate and forward the logs in exactly the same format as mentioned above and the same has been successfully validated in our lab environment as well.

- 1726663202.810 4 10.10.10.10 TCP_DENIED/403 0 CONNECT
tunnel://FORCEPOINTDLP:443/ - NONE/- -
BLOCK_WEBCAT_12-DefaultGroup-match_network-NONE-NONE-NONE-NONE-NONE
<"nc",ns,1,"-",-,-,-,-,"-",-,-,-,"-",-,-,"-","-",-,-,"nc",-,"-","-","-","Unknown","Unknown","-","-",0.00,0,-,"-","-",-,"-",-,-,"-","-",-,-,"-",-,->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are some of the attributes in this list - but others are "-"?

Copy link
Contributor

@ankitarajput-crest ankitarajput-crest Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logs can have both - and "-" and hence the grok parser is designed to handle attributes seamlessly, regardless of whether they are enclosed in double quotes or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants