Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Link with for now doc organisation on logs #1783

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Fix Link with for now doc organisation on logs #1783

merged 1 commit into from
Jun 21, 2018

Conversation

NBParis
Copy link

@NBParis NBParis commented Jun 21, 2018

What does this PR do?

Fix the link to the Fluentd installation instruction

Motivation

Doc organisation was changed and link not updated.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@NBParis NBParis requested a review from a team as a code owner June 21, 2018 08:50
@NBParis NBParis requested a review from l0k0ms June 21, 2018 08:50
l0k0ms
l0k0ms approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@NBParis
Copy link
Author

NBParis commented Jun 21, 2018

@masci Just a link update in this one :)

masci
masci approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@masci masci merged commit 3d11ec3 into master Jun 21, 2018
@masci masci deleted the nils/fluentd-link branch June 21, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@l0k0ms l0k0ms l0k0ms approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NBParis @masci @l0k0ms @gmmeyer