Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the codeowners validation in integrations-core #17199

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Mar 15, 2024

What does this PR do?

Allow the codeowners validation in integrations-core

Motivation

We will very soon extend this validation to also validate stuff in integrations-core

Additional Notes

We do not have any tests for this yet, I'll add them when I'll move them to ddev

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (4771758) to head (9245dbc).
Report is 6 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
datadog_checks_dev 78.55% <ø> (+0.03%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret enabled auto-merge (squash) March 15, 2024 15:05
Copy link

Test Results

  4 files    4 suites   3m 44s ⏱️
391 tests 391 ✅  0 💤 0 ❌
882 runs  849 ✅ 33 💤 0 ❌

Results for commit 9245dbc.

Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of this:

We add a couple simple tests for this in ddev already. We're kinda doing that for the changelog commands which are partially in ddev and partially in dcd. Should help make migration more secure.

Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@FlorentClarret FlorentClarret merged commit 65aa58e into master Mar 15, 2024
54 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/dcd/codeowners branch March 15, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants