Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecos 1214] remove old unused oauth manifest field #16873

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

bgoldberg122
Copy link
Contributor

@bgoldberg122 bgoldberg122 commented Feb 13, 2024

What does this PR do?

remove old unused oauth manifest field from all manifests in favor of manifest.assets.oauth

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@bgoldberg122 bgoldberg122 force-pushed the bgoldberg122/ecos-1214_remove-old-oauth-field branch from e833a09 to 672435c Compare February 13, 2024 23:12
@bgoldberg122 bgoldberg122 force-pushed the bgoldberg122/ecos-1214_remove-old-oauth-field branch from 9c97a5f to 9ce2ab5 Compare February 13, 2024 23:16
@bgoldberg122 bgoldberg122 changed the title [ecos 1214] remove old unused oauth manifest field from all manifests [ecos 1214] remove old unused oauth manifest field Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07c04c5) 90.55% compared to head (a304a2f) 90.67%.
Report is 6 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
datadog_checks_dev 82.53% <ø> (+0.03%) ⬆️
ddev 88.22% <ø> (-0.04%) ⬇️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Feb 13, 2024

Test Results

    6 files      6 suites   8m 2s ⏱️
  893 tests   888 ✅  5 💤 0 ❌
1 886 runs  1 824 ✅ 62 💤 0 ❌

Results for commit a304a2f.

♻️ This comment has been updated with latest results.

JoshPatel13
JoshPatel13 previously approved these changes Feb 14, 2024
@bgoldberg122 bgoldberg122 marked this pull request as ready for review February 14, 2024 15:54
@bgoldberg122 bgoldberg122 requested review from a team as code owners February 14, 2024 15:54
lu-zhengda
lu-zhengda previously approved these changes Feb 14, 2024
@bgoldberg122 bgoldberg122 dismissed stale reviews from lu-zhengda and JoshPatel13 via 72f51b2 February 14, 2024 16:00
@FlorentClarret FlorentClarret merged commit 7352738 into master Feb 14, 2024
50 of 52 checks passed
@FlorentClarret FlorentClarret deleted the bgoldberg122/ecos-1214_remove-old-oauth-field branch February 14, 2024 16:34
NouemanKHAL pushed a commit that referenced this pull request Mar 4, 2024
* remove old unused oauth manifest field from all manifests

* remove oauth field from manifest in ddev

* remove venv3

* run ddev -c release changelog new

* change update type to fixed

* remove changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants