Allow skip loading Python kubelet check based on DD_KUBELET_CORE_CHECK_ENABLED
#16856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennchenn
force-pushed
the
jenn/CONTINT-3778_disable-python-kubelet-check-via-env-var
branch
from
50f1aee to
00b31dc
Compare
Test Results 2 files 2 suites 6s ⏱️ Results for commit e86263a. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
jennchenn
force-pushed
the
jenn/CONTINT-3778_disable-python-kubelet-check-via-env-var
branch
from
00b31dc to
2657ed7
Compare
…isable-python-kubelet-check-via-env-var
clamoriniere
approved these changes
Mar 13, 2024
jennchenn
changed the title
DD_KUBERNETES_KUBELET_CORE_CHECK_ENABLEDDD_KUBELET_CORE_CHECK_ENABLED
jennchenn
deleted the
jenn/CONTINT-3778_disable-python-kubelet-check-via-env-var
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change adds logic to skip loading the Python
kubeletcheck based on the value of the configuration variableDD_KUBELET_CORE_CHECK_ENABLED.Motivation
This is part of the efforts to migrate from the
kubeletPython check to thekubeletcheck defined indatadog-agent. This config variable will be added in DataDog/helm-charts#1319.Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.