Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerate source_type_id when running ddev create #16544

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Jan 6, 2024

What does this PR do?

Adds an auto-generation of "source_type_id" and put it in the manifest.json file during ddev create.

Motivation

This is a field that already exists for all current integrations and followup work will backport the current IDs into the existing manifests.

Otherwise, the rationale can be found here - https://datadoghq.atlassian.net/wiki/spaces/MKT/pages/3306327909/2023-11-27+APW+Integration+Source+Type+ID+Generation

Additional Notes

I was able to test this by running ddev -x create test_integration. Then the resulting test_integration/manifest.json contained the following:

...
  "assets": {
    "integration": {
      "source_type_id": 4526851,
      "source_type_name": "test_integration",
      "configuration": {
        "spec": "assets/configuration/spec.yaml"
      },
...

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (110cec7) 90.54% compared to head (3da69db) 90.64%.
Report is 53 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
datadog_checks_dev 82.55% <100.00%> (+0.03%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Jan 6, 2024

Test Results

  4 files    4 suites   3m 44s ⏱️
430 tests 430 ✅  0 💤 0 ❌
960 runs  927 ✅ 33 💤 0 ❌

Results for commit 3da69db.

Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@FlorentClarret FlorentClarret merged commit 5958d70 into master Jan 17, 2024
52 of 53 checks passed
@FlorentClarret FlorentClarret deleted the nick/ddev_source_type branch January 17, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants