Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare E2E tooling for better message passing #15843

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Prepare E2E tooling for better message passing #15843

merged 1 commit into from
Sep 15, 2023

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Sep 15, 2023

Motivation

Large refactor is incoming and this is the first step

@ofek ofek requested review from a team as code owners September 15, 2023 16:45
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #15843 (581b209) into master (6237ac3) will increase coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Flag Coverage Δ
active_directory 100.00% <ø> (+17.64%) ⬆️
activemq 52.87% <ø> (?)
activemq_xml 82.31% <ø> (ø)
amazon_msk 89.07% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.23% <ø> (ø)
argocd 87.81% <ø> (ø)
aspdotnet 100.00% <ø> (ø)
avi_vantage 91.35% <ø> (ø)
azure_iot_edge 82.08% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 84.61% <ø> (ø)
cassandra 65.51% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cisco_aci 95.27% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
cloud_foundry_api 96.35% <ø> (+0.12%) ⬆️
cloudera 99.49% <ø> (ø)
cockroachdb 91.52% <ø> (ø)
confluent_platform 81.96% <ø> (ø)
consul 91.65% <ø> (ø)
coredns 94.57% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_base 89.67% <ø> (+0.36%) ⬆️
datadog_checks_dev 82.51% <100.00%> (+0.07%) ⬆️
datadog_checks_downloader 81.65% <ø> (ø)
datadog_cluster_agent 90.19% <ø> (ø)
dcgm 97.40% <ø> (ø)
ddev 99.38% <ø> (ø)
directory 95.87% <ø> (+0.65%) ⬆️
disk 89.23% <ø> (-2.14%) ⬇️
dns_check 93.90% <ø> (ø)
druid 98.47% <ø> (ø)
ecs_fargate 82.91% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 93.36% <ø> (ø)
envoy 95.09% <ø> (+0.41%) ⬆️
etcd 95.56% <ø> (ø)
external_dns 89.28% <ø> (ø)
fluentd 94.77% <ø> (ø)
foundationdb 78.50% <ø> (ø)
gitlab 92.10% <ø> (+1.21%) ⬆️
gitlab_runner 91.94% <ø> (ø)
glusterfs 80.09% <ø> (+0.90%) ⬆️
go_expvar 92.73% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
hdfs_namenode 86.72% <ø> (ø)
hive 51.42% <ø> (ø)
hivemq 61.90% <ø> (ø)
http_check 95.51% <ø> (+2.05%) ⬆️
hudi 73.91% <ø> (ø)
ibm_ace 91.89% <ø> (ø)
ibm_db2 95.30% <ø> (ø)
ibm_i 81.91% <ø> (ø)
ibm_mq 91.40% <ø> (+0.13%) ⬆️
ignite 46.66% <ø> (?)
iis 95.05% <ø> (ø)
impala 97.97% <ø> (ø)
istio 76.45% <ø> (+0.55%) ⬆️
jboss_wildfly 47.36% <ø> (ø)
kafka 63.63% <ø> (ø)
kong 87.56% <ø> (ø)
kube_apiserver_metrics 97.85% <ø> (ø)
kube_controller_manager 96.07% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 97.50% <ø> (ø)
kubelet 91.03% <ø> (ø)
kubernetes_state 89.18% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
mapreduce 81.35% <ø> (ø)
marathon 83.43% <ø> (ø)
mcache 93.50% <ø> (ø)
mesos_master 89.75% <ø> (ø)
mysql 87.37% <ø> (ø)
nagios 89.01% <ø> (ø)
network 62.21% <ø> (+1.08%) ⬆️
nfsstat 95.20% <ø> (ø)
nginx_ingress_controller 98.36% <ø> (ø)
openldap 96.79% <ø> (ø)
openmetrics 98.08% <ø> (ø)
openstack 51.45% <ø> (ø)
openstack_controller 91.12% <ø> (ø)
pgbouncer 91.33% <ø> (ø)
php_fpm 90.25% <ø> (+0.84%) ⬆️
postfix 88.04% <ø> (ø)
postgres 91.89% <ø> (+0.06%) ⬆️
powerdns_recursor 96.65% <ø> (ø)
presto 59.09% <ø> (?)
process 85.42% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
pulsar 100.00% <ø> (ø)
rabbitmq 96.04% <ø> (ø)
ray 96.45% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
riak 99.22% <ø> (ø)
riakcs 93.61% <ø> (ø)
sap_hana 91.64% <ø> (+0.26%) ⬆️
silk 93.82% <ø> (ø)
singlestore 90.81% <ø> (ø)
snmp 48.59% <ø> (+0.01%) ⬆️
snowflake 96.61% <ø> (ø)
solr 56.25% <ø> (?)
sonarqube 98.24% <ø> (ø)
spark 93.91% <ø> (+0.28%) ⬆️
sqlserver 87.45% <ø> (ø)
squid 100.00% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
strimzi 89.70% <ø> (ø)
supervisord 90.14% <ø> (ø)
system_core 92.66% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 91.58% <ø> (-1.35%) ⬇️
temporal 100.00% <ø> (ø)
teradata 94.06% <ø> (ø)
tls 92.18% <ø> (+0.82%) ⬆️
tokumx 58.40% <ø> (ø)
tomcat 61.29% <ø> (ø)
torchserve 97.33% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
twistlock 79.62% <ø> (ø)
varnish 84.39% <ø> (+0.26%) ⬆️
weaviate 76.27% <ø> (ø)
weblogic ?
win32_event_log 86.40% <ø> (+0.27%) ⬆️
windows_performance_counters 98.36% <ø> (ø)
wmi_check 92.91% <ø> (ø)
yarn 89.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide some context for this wider refactoring? Just a link to a ticket in the PR description would be great.

@ofek
Copy link
Contributor Author

ofek commented Sep 15, 2023

There is no associated GitHub issue nor internal architecture link

@github-actions
Copy link

Test Results

     998 files       998 suites   8h 21m 13s ⏱️
  6 012 tests   5 940 ✔️      70 💤 1  1 🔥
25 370 runs  21 016 ✔️ 4 352 💤 1  1 🔥

For more details on these failures and errors, see this check.

Results for commit 581b209.

@ofek
Copy link
Contributor Author

ofek commented Sep 15, 2023

Basically I'm switching the communication mechanism between the CLI and tests to be files rather than formatted stdout so we can now show what's happening during setup

@ofek ofek merged commit d69dc07 into master Sep 15, 2023
@ofek ofek deleted the ofek/de branch September 15, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants