Override the default test options for some integrations #15779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Have feedback on the report? Share it here. |
FlorentClarret
changed the title
FlorentClarret
force-pushed
the
florentclarret/ddev/load_conftest_files
branch
from
dd1f476 to
27526e5
Compare
FlorentClarret
force-pushed
the
florentclarret/ddev/load_conftest_files
branch
from
27526e5 to
3e35436
Compare
iliakur
reviewed
Sep 7, 2023
teamcity/hatch.toml
Outdated
| @@ -14,6 +14,7 @@ matrix.impl.env-vars = [ | |||
| ] | |||
| matrix.python.scripts = [ | |||
| { key = "test", value = "_dd-test --ignore=tests/docker" }, | |||
| { key = "test-cov", value = "_dd-test-cov --ignore=tests/docker" }, | |||
There was a problem hiding this comment.
Could we set this flag in a conftest.py or even pyproject.toml? That way it would apply always.
There was a problem hiding this comment.
I don't know 😅 Will wait for ofek on this one if that's ok for you
There was a problem hiding this comment.
yea, looking forward to Ofek's input! iiuc, putting it into config could mean we get rid of that whole section!
FlorentClarret
force-pushed
the
florentclarret/ddev/load_conftest_files
branch
7 times, most recently
from
26ae1b3 to
402579a
Compare
FlorentClarret
force-pushed
the
florentclarret/ddev/load_conftest_files
branch
2 times, most recently
from
0739bc5 to
5225655
Compare
FlorentClarret
changed the title
FlorentClarret
force-pushed
the
florentclarret/ddev/load_conftest_files
branch
2 times, most recently
from
52ee109 to
4cf507b
Compare
FlorentClarret
force-pushed
the
florentclarret/ddev/load_conftest_files
branch
from
8e5fd66 to
f6ea985
Compare
FlorentClarret
force-pushed
the
florentclarret/ddev/load_conftest_files
branch
from
f6ea985 to
cd9ad6b
Compare
julien-lebot
approved these changes
Sep 8, 2023
ofek
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix stuff coming from #15762
pyproject.toml(for python3) orsetup.cfg(for py2)Motivation
https://github.com/DataDog/integrations-core/actions/runs/6105895055/job/16570096990
When we add parameters after
integrations-core/ddev/src/ddev/cli/test/__init__.py
Line 154 in c758504
, they will be forward to
https://github.com/DataDog/integrations-core/blob/master/ddev/src/ddev/plugin/external/hatch/environment_collector.py#L114-L119 as
argsand we loose thetestspart of the command, which make us load everything.Trigger all the tests when ddev is modified, similar to what we do with
datadog_checks_dev.Additional Notes
Adding a default
setup.cfgfile at the root does not work (I might have a look at that a bit later, my priority is to have our CI green)I'll open follow-up PRs to configure this by default for most of the integrations.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.