Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setuptools from the build-system for new integrations #15766

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Remove setuptools from the build-system for new integrations #15766

merged 1 commit into from
Sep 7, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Sep 6, 2023 •
edited
Loading

What does this PR do?

Remove setuptools from the build-system for new integrations

Motivation

#15441 (comment)

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret FlorentClarret requested a review from a team as a code owner September 6, 2023 12:34
@FlorentClarret FlorentClarret force-pushed the florentclarret/dcd/build_template_setupttols branch from d887796 to 47efa5e Compare September 6, 2023 12:35
@FlorentClarret FlorentClarret requested a review from a team as a code owner September 6, 2023 12:35
@ghost ghost added the documentation label Sep 6, 2023
@FlorentClarret FlorentClarret mentioned this pull request Sep 6, 2023
Merged
5 tasks
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #15766 (47efa5e) into master (aafc898) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 82.51% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Test Results

    4 files      4 suites   4m 20s ⏱️
418 tests 418 ✔️   0 💤 0 ❌
936 runs  903 ✔️ 33 💤 0 ❌

Results for commit 47efa5e.

iliakur
iliakur approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'm surprised this slipped thru the cracks when we were removing it earlier...

@jhgilbert jhgilbert self-assigned this Sep 6, 2023
@FlorentClarret FlorentClarret merged commit 526b71c into master Sep 7, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/dcd/build_template_setupttols branch September 7, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhgilbert jhgilbert jhgilbert approved these changes

@iliakur iliakur iliakur approved these changes

Assignees

@jhgilbert jhgilbert

Labels
dev_package dev/tooling documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorentClarret @iliakur @jhgilbert