Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to upgrade dependencies that break our tests #15226

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Do not attempt to upgrade dependencies that break our tests #15226

merged 4 commits into from
Jul 11, 2023

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Jul 10, 2023

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@iliakur iliakur requested a review from a team as a code owner July 10, 2023 16:50
@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

Test Results

    4 files      4 suites   11m 50s ⏱️
424 tests 424 ✔️   0 💤 0 ❌
948 runs  915 ✔️ 33 💤 0 ❌

Results for commit 1886776.

♻️ This comment has been updated with latest results.

@iliakur @ofek
Update datadog_checks_dev/datadog_checks/dev/tooling/commands/dep.py
8f00d0d 
Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
FlorentClarret
FlorentClarret previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@iliakur iliakur requested a review from FlorentClarret July 11, 2023 07:36
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #15226 (1886776) into master (f2bcac8) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 82.77% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@iliakur iliakur merged commit 4199996 into master Jul 11, 2023
@iliakur iliakur deleted the ik/ignore-breaking-deps branch July 11, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek left review comments

@FlorentClarret FlorentClarret FlorentClarret approved these changes

Assignees
No one assigned
Labels
dev_package dev/tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iliakur @FlorentClarret @ofek