Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ddev script from datadog_checks_dev #14837

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

swang392
Copy link
Contributor

@swang392 swang392 commented Jun 22, 2023

What does this PR do?

Remove ddev script from datadog_checks_dev. The new CLI package provides that and therefore this is a duplicate that can potentially cause conflicts

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@swang392 swang392 requested a review from a team as a code owner June 22, 2023 16:56
@ghost ghost added the dev_package label Jun 22, 2023
@github-actions
Copy link

Test Results

    2 files      2 suites   7m 47s ⏱️
424 tests 424 ✔️   0 💤 0
848 runs  830 ✔️ 18 💤 0

Results for commit adea9a3.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #14837 (adea9a3) into master (b5e51ff) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 82.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@swang392 swang392 merged commit b34ffec into master Jun 22, 2023
@swang392 swang392 deleted the swang392/remove-ddev-conflict branch June 22, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants