Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Capture stderr from docker compose to improve debugging experience" (#13949) #14714

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jun 8, 2023

What does this PR do?

This reverts commit 8fe3614.

Motivation

This change broke our confluent_platform tests. We will try to find another approach to fix the original issue.

Additional Notes

cc @iliakur as the original author and we discussed about that today

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@FlorentClarret FlorentClarret requested a review from a team as a code owner June 8, 2023 18:13
@FlorentClarret FlorentClarret changed the title Revert "Capture stderr from docker compose to improve debugging experience (#13949) Revert "Capture stderr from docker compose to improve debugging experience" (#13949) Jun 8, 2023
@ghost ghost added the dev_package label Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #14714 (829938a) into master (cfc51d2) will increase coverage by 0.13%.
The diff coverage is 0.00%.

Flag Coverage Δ
active_directory 100.00% <ø> (+17.64%) ⬆️
activemq_xml 82.31% <ø> (ø)
aerospike 87.17% <ø> (+0.32%) ⬆️
airflow 90.00% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.23% <ø> (ø)
argocd 88.43% <ø> (ø)
aspdotnet 100.00% <ø> (+26.19%) ⬆️
avi_vantage 92.54% <ø> (ø)
azure_iot_edge 82.08% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 83.54% <ø> (ø)
cassandra_nodetool 93.16% <ø> (ø)
ceph 91.02% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cilium 75.46% <ø> (+0.92%) ⬆️
cisco_aci 95.27% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
clickhouse 95.49% <ø> (ø)
cloud_foundry_api 96.35% <ø> (+0.12%) ⬆️
cloudera 99.82% <ø> (ø)
cockroachdb 91.90% <ø> (ø)
consul 91.65% <ø> (ø)
couch 95.43% <ø> (+0.24%) ⬆️
couchbase 84.28% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_base 89.18% <ø> (-0.06%) ⬇️
datadog_checks_dev 80.16% <0.00%> (-2.58%) ⬇️
datadog_checks_downloader 81.65% <ø> (ø)
datadog_cluster_agent 90.19% <ø> (ø)
ddev 99.20% <ø> (ø)
directory 96.09% <ø> (+0.65%) ⬆️
disk 90.38% <ø> (-0.96%) ⬇️
dns_check 93.90% <ø> (ø)
druid 98.47% <ø> (ø)
ecs_fargate 80.92% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 93.22% <ø> (ø)
envoy 95.02% <ø> (+0.42%) ⬆️
etcd 95.56% <ø> (ø)
external_dns 89.28% <ø> (ø)
fluentd 94.77% <ø> (ø)
foundationdb 78.50% <ø> (ø)
gitlab_runner 91.94% <ø> (ø)
go_expvar 92.73% <ø> (ø)
haproxy 95.13% <ø> (+0.16%) ⬆️
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
hdfs_namenode 86.72% <ø> (ø)
http_check 96.09% <ø> (+2.15%) ⬆️
ibm_ace 91.79% <ø> (ø)
ibm_db2 95.30% <ø> (ø)
ibm_i 81.95% <ø> (ø)
ibm_was 96.08% <ø> (ø)
iis 95.00% <ø> (+37.60%) ⬆️
impala 97.97% <ø> (ø)
istio 77.43% <ø> (+0.55%) ⬆️
kafka_consumer 93.43% <ø> (ø)
kube_apiserver_metrics 98.10% <ø> (ø)
kube_controller_manager 96.00% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 96.53% <ø> (ø)
kubelet 90.90% <ø> (ø)
kubernetes_state 89.18% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linux_proc_extras 96.22% <ø> (ø)
mapreduce 81.81% <ø> (+0.46%) ⬆️
marathon 83.43% <ø> (ø)
marklogic 96.46% <ø> (ø)
mcache 93.50% <ø> (ø)
mesos_master 89.75% <ø> (ø)
nagios 89.01% <ø> (ø)
network 94.01% <ø> (+1.10%) ⬆️
nfsstat 95.20% <ø> (ø)
nginx 97.83% <ø> (+3.12%) ⬆️
nginx_ingress_controller 98.36% <ø> (ø)
openldap 96.79% <ø> (ø)
openmetrics 98.08% <ø> (ø)
openstack 51.45% <ø> (ø)
openstack_controller 91.12% <ø> (ø)
oracle 89.78% <ø> (ø)
pgbouncer 91.33% <ø> (ø)
php_fpm 90.25% <ø> (+0.84%) ⬆️
postfix 88.04% <ø> (ø)
postgres 91.04% <ø> (-0.06%) ⬇️
powerdns_recursor 96.65% <ø> (ø)
process 85.42% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
pulsar 100.00% <ø> (ø)
riak 99.22% <ø> (ø)
scylla 100.00% <ø> (ø)
silk 93.82% <ø> (ø)
singlestore 90.81% <ø> (ø)
snmp 82.58% <ø> (+0.03%) ⬆️
snowflake 96.76% <ø> (ø)
sonarqube 98.24% <ø> (ø)
spark 93.91% <ø> (ø)
squid 100.00% <ø> (ø)
ssh_check 91.58% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
supervisord 92.69% <ø> (ø)
system_core 90.90% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 92.92% <ø> (ø)
teamcity 88.35% <ø> (+2.87%) ⬆️
temporal 100.00% <ø> (ø)
teradata 94.24% <ø> (ø)
tls 92.18% <ø> (+0.82%) ⬆️
tokumx 58.40% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
twistlock 79.62% <ø> (ø)
varnish 84.39% <ø> (+0.26%) ⬆️
vault 95.53% <ø> (+0.57%) ⬆️
vertica 98.50% <ø> (ø)
win32_event_log 86.68% <ø> (+0.55%) ⬆️
windows_performance_counters 98.36% <ø> (ø)
windows_service 98.00% <ø> (ø)
yarn 89.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret merged commit f1544b0 into master Jun 8, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/ddev/debug_rolback branch June 8, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants