Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token and alert as valid metric units #14575

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

steveny91
Copy link
Contributor

@steveny91 steveny91 commented May 16, 2023

What does this PR do?

Alert was added previously to the catalog.csv, token has also been added

@steveny91 steveny91 changed the title Add missing metric units to validations Add token and alert as valid metric units May 16, 2023
@steveny91 steveny91 marked this pull request as ready for review May 16, 2023 15:02
@steveny91 steveny91 requested a review from a team as a code owner May 16, 2023 15:02
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #14575 (589ff24) into master (0b4e857) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 82.75% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

Test Results

    4 files      4 suites   13m 57s ⏱️
424 tests 424 ✔️   0 💤 0
948 runs  915 ✔️ 33 💤 0

Results for commit 589ff24.

@steveny91 steveny91 merged commit 8bbccee into master May 16, 2023
@steveny91 steveny91 deleted the sy/add-token-unit branch May 16, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants