-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip metadata validation for non-metrics integrations. #14211
Merged
ofek
merged 2 commits into
master
from
nathan.adams/skip-metadata-validation-non-metrics-int
Mar 23, 2023
Merged
Skip metadata validation for non-metrics integrations. #14211
ofek
merged 2 commits into
master
from
nathan.adams/skip-metadata-validation-non-metrics-int
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
nmuesch
reviewed
Mar 22, 2023
datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/metadata.py
Outdated
Show resolved
Hide resolved
…e/metadata.py Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com>
nmuesch
approved these changes
Mar 22, 2023
iliakur
approved these changes
Mar 23, 2023
ofek
approved these changes
Mar 23, 2023
steveny91
pushed a commit
that referenced
this pull request
Mar 30, 2023
* Skip metadata validation for non-metrics integrations. * Update datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/metadata.py Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com> --------- Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skips metrics metadata CSV validation if the integration isn't a metrics integration.
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.