Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip metadata validation for non-metrics integrations. #14211

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

nathanmadams
Copy link
Contributor

What does this PR do?

Skips metrics metadata CSV validation if the integration isn't a metrics integration.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@nathanmadams nathanmadams requested a review from a team as a code owner March 22, 2023 21:10
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #14211 (037ccf3) into master (6609f0a) will increase coverage by 0.39%.
The diff coverage is n/a.

Flag Coverage Δ
active_directory 100.00% <ø> (+17.64%) ⬆️
activemq_xml 82.31% <ø> (ø)
aerospike 87.17% <ø> (+0.32%) ⬆️
airflow 90.00% <ø> (ø)
amazon_msk 89.07% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.21% <ø> (ø)
argocd 88.43% <ø> (ø)
aspdotnet 100.00% <ø> (+26.19%) ⬆️
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 83.33% <ø> (ø)
cassandra_nodetool 93.16% <ø> (ø)
ceph 91.02% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cilium 75.34% <ø> (+0.93%) ⬆️
citrix_hypervisor 87.50% <ø> (ø)
clickhouse 95.49% <ø> (ø)
cloud_foundry_api 95.98% <ø> (+0.12%) ⬆️
cockroachdb 90.96% <ø> (ø)
consul 91.64% <ø> (ø)
coredns 94.54% <ø> (ø)
couch 95.19% <ø> (+0.24%) ⬆️
couchbase 84.28% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_base 89.67% <ø> (+0.34%) ⬆️
datadog_cluster_agent 90.00% <ø> (ø)
directory 96.50% <ø> (ø)
disk 91.78% <ø> (ø)
dns_check 93.90% <ø> (ø)
dotnetclr 94.93% <ø> (+15.18%) ⬆️
druid 97.70% <ø> (ø)
ecs_fargate 80.92% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 91.61% <ø> (ø)
envoy 94.18% <ø> (ø)
etcd 93.96% <ø> (ø)
exchange_server 96.85% <ø> (+11.81%) ⬆️
external_dns 89.09% <ø> (ø)
fluentd 94.77% <ø> (ø)
foundationdb 78.50% <ø> (-0.30%) ⬇️
gearmand 78.26% <ø> (+1.24%) ⬆️
gitlab 89.94% <ø> (ø)
gitlab_runner 91.94% <ø> (ø)
glusterfs 80.09% <ø> (+0.92%) ⬆️
go_expvar 92.73% <ø> (ø)
gunicorn 92.10% <ø> (-0.76%) ⬇️
haproxy 95.13% <ø> (+0.16%) ⬆️
harbor 80.04% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
hdfs_namenode 86.72% <ø> (ø)
ibm_ace 91.79% <ø> (ø)
ibm_db2 95.10% <ø> (ø)
ibm_i 81.95% <ø> (ø)
ibm_mq 91.37% <ø> (ø)
ibm_was 96.08% <ø> (ø)
iis 95.00% <ø> (+37.60%) ⬆️
istio 77.43% <ø> (+0.55%) ⬆️
kafka_consumer 84.06% <ø> (ø)
kong 87.56% <ø> (ø)
kube_apiserver_metrics 97.95% <ø> (ø)
kube_controller_manager 96.00% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kubelet 90.96% <ø> (ø)
kubernetes_state 89.18% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
mapreduce 81.81% <ø> (+0.46%) ⬆️
marathon 83.12% <ø> (ø)
marklogic 96.03% <ø> (ø)
mesos_master 89.75% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
mongo 96.63% <ø> (ø)
network 93.99% <ø> (+0.94%) ⬆️
nginx 95.24% <ø> (+0.54%) ⬆️
nginx_ingress_controller 98.36% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 97.90% <ø> (ø)
openstack 51.45% <ø> (ø)
openstack_controller 91.12% <ø> (ø)
oracle 90.46% <ø> (ø)
pdh_check 95.65% <ø> (ø)
pgbouncer 91.33% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
process 85.42% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
pulsar 100.00% <ø> (ø)
redisdb 87.50% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
riakcs 93.61% <ø> (ø)
sap_hana 91.37% <ø> (ø)
scylla 100.00% <ø> (ø)
silk 93.51% <ø> (ø)
singlestore 90.81% <ø> (ø)
snmp 85.22% <ø> (+0.04%) ⬆️
snowflake 96.47% <ø> (ø)
spark 93.63% <ø> (ø)
squid 100.00% <ø> (ø)
ssh_check 91.58% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
supervisord 92.30% <ø> (ø)
system_core 90.90% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 91.58% <ø> (ø)
teamcity 88.35% <ø> (+2.87%) ⬆️
teradata 94.24% <ø> (ø)
tls 91.82% <ø> (+0.84%) ⬆️
tokumx 58.40% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
twistlock 79.62% <ø> (ø)
varnish 84.39% <ø> (+0.26%) ⬆️
vault 95.53% <ø> (+0.57%) ⬆️
vertica 98.50% <ø> (ø)
voltdb 96.84% <ø> (ø)
vsphere 89.91% <ø> (+0.08%) ⬆️
win32_event_log 86.40% <ø> (+0.27%) ⬆️
windows_performance_counters 98.36% <ø> (ø)
windows_service 98.00% <ø> (ø)
wmi_check 92.91% <ø> (ø)
yarn 89.50% <ø> (ø)
zk 82.62% <ø> (+1.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

…e/metadata.py

Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com>
@nathanmadams nathanmadams requested a review from nmuesch March 22, 2023 21:24
@ofek ofek merged commit 758c9a7 into master Mar 23, 2023
@ofek ofek deleted the nathan.adams/skip-metadata-validation-non-metrics-int branch March 23, 2023 15:19
@FlorentClarret FlorentClarret mentioned this pull request Mar 24, 2023
5 tasks
steveny91 pushed a commit that referenced this pull request Mar 30, 2023
* Skip metadata validation for non-metrics integrations.

* Update datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/metadata.py

Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com>

---------

Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants