-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify the mode when creating a temp dir #14208
Allow to specify the mode when creating a temp dir #14208
Conversation
5631320
to
d087c02
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting a dejavu with this change of a PR I saw when I just started, I can swear it was also about exposing the mode
of tempdirs. I can't find it naturally :)
I'll fix the windows tests this afternoon |
d087c02
to
1567887
Compare
bee2f71
to
4ecb59b
Compare
What does this PR do?
Allow to specify the mode when creating a temp dir
Motivation
0o700
, see https://github.com/python/cpython/blob/main/Lib/tempfile.py#L344-L379root
user can access and modify this folder, however some of the docker images I have are using a different user, so this user can't access the data and write to this folder. I ended up callingchmod
on my side and it workedAdditional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.