Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling of tracing for tests with an environment variable #14206

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Mar 21, 2023

Motivation

Conditional enablement with an environment variable is much easier for CI configuration than formatting a command with the flag

@ofek ofek requested a review from a team as a code owner March 21, 2023 22:42
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #14206 (d66079c) into master (b24ab84) will decrease coverage by 0.03%.
The diff coverage is n/a.

Flag Coverage Δ
ambari 85.75% <ø> (ø)
arangodb 98.21% <ø> (ø)
argocd 88.43% <ø> (ø)
avi_vantage 92.54% <ø> (ø)
azure_iot_edge 82.00% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
cisco_aci 95.27% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
cloud_foundry_api 95.98% <ø> (+0.12%) ⬆️
cloudera 99.82% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_downloader 80.48% <ø> (ø)
ddev 98.64% <ø> (ø)
disk 89.64% <ø> (-2.15%) ⬇️
dns_check 93.90% <ø> (ø)
druid 97.70% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
foundationdb 78.50% <ø> (-0.30%) ⬇️
gunicorn 92.10% <ø> (ø)
hazelcast 92.39% <ø> (ø)
ibm_i 81.95% <ø> (ø)
kube_apiserver_metrics 97.95% <ø> (ø)
kube_controller_manager 96.00% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 96.53% <ø> (ø)
kubelet 90.96% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
nagios 89.01% <ø> (ø)
openmetrics 97.90% <ø> (ø)
openstack_controller 91.12% <ø> (ø)
php_fpm 90.25% <ø> (+0.84%) ⬆️
pulsar 100.00% <ø> (ø)
riak 99.22% <ø> (ø)
silk 93.51% <ø> (ø)
singlestore 90.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek merged commit efbf2c5 into master Mar 21, 2023
@ofek ofek deleted the ofek/dtev branch March 21, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant