-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always recreate the containers when using docker-compose in tests #13685
Always recreate the containers when using docker-compose in tests #13685
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if we want the containers to persist, we do it outside of automated tests in custom setups.
They do persist if they're stopped. With this option we recreate them in case you're re-running the |
What does this PR do?
Always recreate the containers when using docker-compose in tests
Motivation
Additional Notes
To rest it:
ddev env start cloudera py3.8
docker stop dd_cloudera_py3.8 cloudera
or or reboot the docker daemon/your computerddev env start cloudera py3.8
-> it should workReview checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.