Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style #13518

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Fix style #13518

merged 1 commit into from
Dec 19, 2022

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Dec 14, 2022

What does this PR do?

Fix style issues in datadog_checks_dev

Motivation

We bumped flake8 and missed the errors

https://dev.azure.com/datadoghq/integrations-core/_build/results?buildId=122022&view=logs&jobId=40b3f23d-1644-5d89-acd8-67daa1a59c69&j=40b3f23d-1644-5d89-acd8-67daa1a59c69&t=1cb4eb6e-5673-5999-7c1c-994687145201

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@FlorentClarret FlorentClarret requested a review from a team as a code owner December 14, 2022 15:06
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #13518 (7a712ce) into master (786fa2e) will increase coverage by 0.16%.
The diff coverage is n/a.

Flag Coverage Δ
activemq_xml 82.31% <ø> (ø)
airflow 90.00% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.21% <ø> (ø)
argocd 88.13% <ø> (ø)
avi_vantage 92.50% <ø> (ø)
azure_iot_edge 82.00% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 83.33% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cilium 75.34% <ø> (+0.93%) ⬆️
cisco_aci 95.27% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
cloud_foundry_api 95.98% <ø> (+0.12%) ⬆️
cockroachdb 90.96% <ø> (ø)
consul 91.64% <ø> (ø)
couchbase 83.58% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_base 89.51% <ø> (+0.35%) ⬆️
datadog_checks_dev 81.98% <ø> (+0.07%) ⬆️
datadog_checks_downloader 78.64% <ø> (+0.99%) ⬆️
datadog_cluster_agent 90.00% <ø> (ø)
directory 96.50% <ø> (ø)
disk 89.53% <ø> (-2.17%) ⬇️
dns_check 93.90% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 80.05% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 91.61% <ø> (ø)
envoy 94.23% <ø> (ø)
fluentd 94.77% <ø> (ø)
foundationdb 83.88% <ø> (ø)
gearmand 78.26% <ø> (+1.24%) ⬆️
gitlab_runner 91.94% <ø> (ø)
go_expvar 92.73% <ø> (ø)
gunicorn 92.85% <ø> (ø)
haproxy 95.12% <ø> (+0.16%) ⬆️
harbor 80.04% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
http_check 95.38% <ø> (+2.08%) ⬆️
ibm_ace 91.79% <ø> (ø)
ibm_i 81.95% <ø> (ø)
ibm_mq 91.08% <ø> (ø)
ibm_was 96.08% <ø> (ø)
iis 94.61% <ø> (+38.78%) ⬆️
impala 97.97% <ø> (ø)
istio 77.65% <ø> (+0.55%) ⬆️
kong 87.56% <ø> (ø)
kube_apiserver_metrics 97.69% <ø> (ø)
kube_controller_manager 96.00% <ø> (ø)
kube_dns 95.33% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.89% <ø> (ø)
kube_scheduler 96.53% <ø> (ø)
kubelet 90.96% <ø> (ø)
kubernetes_state 89.18% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
mapreduce 81.77% <ø> (+0.46%) ⬆️
marathon 83.12% <ø> (ø)
marklogic 96.03% <ø> (ø)
mcache 93.26% <ø> (ø)
mesos_master 89.75% <ø> (ø)
mongo 96.49% <ø> (ø)
nagios 89.01% <ø> (ø)
network 93.92% <ø> (+0.95%) ⬆️
nfsstat 95.20% <ø> (ø)
nginx 95.24% <ø> (+0.54%) ⬆️
nginx_ingress_controller 98.36% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 97.90% <ø> (ø)
openstack 51.45% <ø> (ø)
openstack_controller 90.94% <ø> (ø)
oracle 90.26% <ø> (ø)
pgbouncer 91.33% <ø> (ø)
php_fpm 90.25% <ø> (+0.84%) ⬆️
postfix 88.04% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
process 85.42% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
pulsar 100.00% <ø> (ø)
rabbitmq 94.41% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
riak 99.22% <ø> (ø)
riakcs 93.61% <ø> (ø)
silk 93.33% <ø> (ø)
singlestore 90.81% <ø> (ø)
snowflake 96.47% <ø> (ø)
spark 93.83% <ø> (+0.28%) ⬆️
squid 100.00% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
supervisord 92.30% <ø> (ø)
system_core 90.90% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 91.58% <ø> (ø)
teradata 94.24% <ø> (ø)
tls 91.82% <ø> (+0.84%) ⬆️
tokumx 58.40% <ø> (?)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
varnish 84.39% <ø> (+0.26%) ⬆️
yarn 89.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret merged commit 7489d48 into master Dec 19, 2022
@FlorentClarret FlorentClarret deleted the florentclarret/dcd/style branch December 19, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants