Add new ddev create type for metrics crawler integrations #13411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
nathanmadams
changed the title
drichards-87
previously approved these changes
Dec 2, 2022
...cks_dev/datadog_checks/dev/tooling/templates/integration/metrics_pull/{check_name}/README.md
Outdated
Show resolved
Hide resolved
nathanmadams
dismissed stale reviews from FlorentClarret and drichards-87
via
90587c6
…ation/metrics_pull/{check_name}/README.md
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
FlorentClarret
approved these changes
Dec 6, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Add new ddev create type for tile-only metrics integrations.
* Rename type
* Update datadog_checks_dev/datadog_checks/dev/tooling/templates/integration/metrics_pull/{check_name}/README.md
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> 74e7501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a type called
metrics_pullto theddev createthat generates the boilerplate for crawler-based metrics integrations.Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attachedqa/skip-qalabel.