Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent metadata validation from crashing on missing columns #12680

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Aug 4, 2022

What does this PR do?

Fixes metadata validation so it does not break when finding missing columns

Motivation

metadata validation currently breaks when displaying errors for integrations extras (error fixed in DataDog/integrations-extras#1384):

/integrations-core/datadog_checks_dev/datadog_checks/dev/tooling/commands/console.py", line 35, in annotate_display_queue
    for func, message in display_queue:
TypeError: cannot unpack non-iterable NoneType object

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #12680 (728aa2a) into master (70e91b9) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
avi_vantage 91.92% <ø> (ø)
btrfs 82.91% <ø> (ø)
calico 83.33% <ø> (ø)
crio 89.79% <ø> (ø)
ddev 97.99% <ø> (ø)
hazelcast 92.39% <ø> (ø)
ibm_i 81.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt marked this pull request as ready for review August 4, 2022 17:48
@sarah-witt sarah-witt requested a review from a team as a code owner August 4, 2022 17:48
@sarah-witt sarah-witt changed the title Fix metadata validation Prevent metadata validation from crashing on missing columns Aug 4, 2022
@sarah-witt sarah-witt merged commit 0a6877b into master Aug 4, 2022
@sarah-witt sarah-witt deleted the sarah/fix-metadata-validation branch August 4, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants