Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better failed assertion message, print return code #12615

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Jul 28, 2022

Print a more comprehensive assertion message on metadata count failure.
Print return code when running additional startup commands on agent image fails

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #12615 (d43fa94) into master (790614a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
arangodb 98.21% <ø> (ø)
avi_vantage 91.92% <ø> (ø)
boundary 100.00% <ø> (ø)
calico 83.33% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
disk 89.42% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
hazelcast 92.39% <ø> (ø)
ibm_i 81.58% <ø> (ø)
istio 77.65% <ø> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jose-manuel-almaza jose-manuel-almaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful

vickenty
vickenty previously approved these changes Jul 28, 2022
@hithwen hithwen dismissed stale reviews from vickenty and jose-manuel-almaza via d43fa94 July 28, 2022 10:21
Co-authored-by: Vickenty Fesunov <vickenty@users.noreply.github.com>
@hithwen hithwen merged commit f7e6d33 into master Jul 28, 2022
@hithwen hithwen deleted the js/improve-error-messages branch July 28, 2022 10:59
github-actions bot pushed a commit that referenced this pull request Jul 28, 2022
* Better failed assertion message, print return code

Co-authored-by: Vickenty Fesunov <vickenty@users.noreply.github.com> f7e6d33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants