Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure process_signatures gets migrated during V2 migrations #12589

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Jul 25, 2022

What does this PR do?

Make sure that process_signatures gets migrated to the manifest V2 format when running the ddev meta manifest migrate command

Motivation

Final piece to fully support process_signatures in manifest V2

Additional Notes

I confirmed this works locally by running ddev -x meta manifest migrate activemq 2.0.0
and confirming the manifest included this section at the bottom of the integration asset:

...
      "process_signatures": [
        "activemq"
      ]
...

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #12589 (593ed2f) into master (a48b506) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
arangodb 98.21% <ø> (ø)
disk 89.42% <ø> (ø)
fluentd 94.77% <ø> (ø)
ibm_i 81.58% <ø> (ø)
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
silk 93.33% <ø> (ø)
system_core 92.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek merged commit a9964d1 into master Aug 19, 2022
@ofek ofek deleted the nick/migrate_cmd_ps branch August 19, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants