Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Impala integration #12548

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Add the Impala integration #12548

merged 1 commit into from
Sep 16, 2022

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jul 20, 2022 •
edited
Loading

What does this PR do?

Add the Impala Integration.

I already merged all the sub-PRs that contained part of this final PR.

Motivation

Q2 OKR.

Additional Notes

This is a massive PR, so I will try to make it as easy to review as possible. I will open several PRs with one purpose and we'll see how it goes.

Metrics

Logs

Dashboards

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the dev/testing label Jul 20, 2022
@DataDog DataDog deleted a comment from github-actions bot Jul 20, 2022
@DataDog DataDog deleted a comment from github-actions bot Jul 20, 2022
@DataDog DataDog deleted a comment from github-actions bot Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #12548 (95e00e7) into master (99ab510) will increase coverage by 0.07%.
The diff coverage is 97.78%.

❗ Current head 95e00e7 differs from pull request most recent head e00192d. Consider uploading reports for the commit e00192d to get more accurate results

Flag Coverage Δ
cert_manager ?
impala 97.78% <97.78%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@DataDog DataDog deleted a comment from github-actions bot Jul 21, 2022
hithwen
hithwen reviewed Jul 25, 2022
View reviewed changes
impala/tox.ini Outdated Show resolved Hide resolved
@FlorentClarret FlorentClarret force-pushed the florentclarret/AI-2526-impala-integration branch 2 times, most recently from 30985b1 to fc74013 Compare July 28, 2022 07:01
@DataDog DataDog deleted a comment from github-actions bot Jul 28, 2022
@DataDog DataDog deleted a comment from github-actions bot Jul 28, 2022
@DataDog DataDog deleted a comment from github-actions bot Jul 28, 2022
@DataDog DataDog deleted a comment from github-actions bot Jul 28, 2022
@FlorentClarret FlorentClarret force-pushed the florentclarret/AI-2526-impala-integration branch from 5c66cc5 to 314dc85 Compare August 1, 2022 07:03
@FlorentClarret FlorentClarret force-pushed the florentclarret/AI-2526-impala-integration branch 3 times, most recently from b0f4f5c to 3e8bb6f Compare August 8, 2022 13:12
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@FlorentClarret FlorentClarret force-pushed the florentclarret/AI-2526-impala-integration branch from 602dcb3 to 01122c4 Compare August 22, 2022 08:10
@FlorentClarret FlorentClarret mentioned this pull request Aug 22, 2022
Merged
4 tasks
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@FlorentClarret FlorentClarret marked this pull request as ready for review August 22, 2022 15:44
@FlorentClarret FlorentClarret requested review from a team as code owners August 22, 2022 15:44
@maycmlee
Copy link
Contributor

maycmlee commented Aug 22, 2022 •
edited
Loading

Created DOCS-3968 for docs review.

@maycmlee maycmlee added the editorial review Waiting on a more in-depth review from a docs team editor label Aug 22, 2022
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@FlorentClarret FlorentClarret force-pushed the florentclarret/AI-2526-impala-integration branch from 5d89144 to 135c82a Compare September 12, 2022 09:39
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@FlorentClarret FlorentClarret force-pushed the florentclarret/AI-2526-impala-integration branch 2 times, most recently from b234930 to ce2036e Compare September 13, 2022 06:20
cswatt
cswatt previously approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have one remaining typo edit! however, i'm going to approve so you can ship once that typo is fixed.

impala/README.md Outdated Show resolved Hide resolved
sarah-witt
sarah-witt requested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

impala/README.md Show resolved Hide resolved
impala/README.md Show resolved Hide resolved
impala/datadog_checks/impala/check.py Outdated Show resolved Hide resolved
impala/datadog_checks/impala/metrics_daemon.py Show resolved Hide resolved
impala/tests/load_tests/agent/conf.yaml Show resolved Hide resolved
impala/datadog_checks/impala/check.py Show resolved Hide resolved
impala/datadog_checks/impala/metrics_daemon.py Show resolved Hide resolved
impala/assets/dashboards/impala_daemon_overview.json Outdated Show resolved Hide resolved
impala/assets/dashboards/impala_catalog_overview.json Outdated Show resolved Hide resolved
impala/assets/dashboards/impala_overview.json Outdated Show resolved Hide resolved
@ghost ghost removed the changelog/no-changelog label Sep 15, 2022
@FlorentClarret FlorentClarret force-pushed the florentclarret/AI-2526-impala-integration branch 6 times, most recently from 36bb4aa to aba02c0 Compare September 15, 2022 09:15
@FlorentClarret FlorentClarret force-pushed the florentclarret/AI-2526-impala-integration branch from aba02c0 to 4e5df3c Compare September 15, 2022 15:56
cswatt
cswatt previously approved these changes Sep 15, 2022
View reviewed changes
sarah-witt
sarah-witt reviewed Sep 15, 2022
View reviewed changes
impala/README.md Outdated Show resolved Hide resolved
impala/README.md Outdated Show resolved Hide resolved
sarah-witt
sarah-witt previously approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@FlorentClarret FlorentClarret dismissed stale reviews from sarah-witt and cswatt via 95e00e7 September 16, 2022 06:24
@FlorentClarret @sarah-witt @cswatt
Add the Impala integration
e00192d 
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
Co-authored-by: cecilia saixue watt <cecilia.watt@datadoghq.com>
@FlorentClarret FlorentClarret force-pushed the florentclarret/AI-2526-impala-integration branch from 95e00e7 to e00192d Compare September 16, 2022 06:31
@FlorentClarret FlorentClarret merged commit 9b52ec4 into master Sep 16, 2022
@FlorentClarret FlorentClarret deleted the florentclarret/AI-2526-impala-integration branch September 16, 2022 06:57
github-actions bot pushed a commit that referenced this pull request Sep 16, 2022
@FlorentClarret @sarah-witt
Add the Impala integration (#12548)
dd00a22 
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
Co-authored-by: cecilia saixue watt <cecilia.watt@datadoghq.com>

Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
Co-authored-by: cecilia saixue watt <cecilia.watt@datadoghq.com> 9b52ec4
steveny91 pushed a commit that referenced this pull request Oct 27, 2022
@FlorentClarret @sarah-witt
@cswatt @steveny91
Add the Impala integration (#12548)
bf574cb 
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
Co-authored-by: cecilia saixue watt <cecilia.watt@datadoghq.com>

Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
Co-authored-by: cecilia saixue watt <cecilia.watt@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen left review comments

@buraizu buraizu buraizu left review comments

@sarah-witt sarah-witt sarah-witt left review comments

@cswatt cswatt cswatt left review comments

Assignees
No one assigned
Labels
dev/testing dev/tooling documentation editorial review Waiting on a more in-depth review from a docs team editor integration/impala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FlorentClarret @maycmlee @hithwen @cswatt @sarah-witt @buraizu