Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add urllib3 as dependency #11069

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Add urllib3 as dependency #11069

merged 3 commits into from
Jan 7, 2022

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

Adds urllib3 as a dependency and pins version to 1.26.8

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@fanny-jiang fanny-jiang requested review from a team as code owners January 7, 2022 23:21
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

yzhan289
yzhan289 previously approved these changes Jan 7, 2022
View reviewed changes
@yzhan289
Copy link
Contributor

yzhan289 commented Jan 7, 2022

Dependency needs to be synced

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@fanny-jiang fanny-jiang requested a review from yzhan289 January 7, 2022 23:37
@yzhan289 yzhan289 merged commit 3ef0562 into master Jan 7, 2022
@yzhan289 yzhan289 deleted the fanny/http-urllib3 branch January 7, 2022 23:41
github-actions bot pushed a commit that referenced this pull request Jan 7, 2022
@yzhan289
Add urllib3 as dependency (#11069)
9e4839b 
* add urllib3 as dependency, remove try/catch

* sync deps

* sync licenses 3ef0562
fanny-jiang added a commit that referenced this pull request Jan 7, 2022
@fanny-jiang
Add urllib3 as dependency (#11069)
e8f8eed 
* add urllib3 as dependency, remove try/catch

* sync deps

* sync licenses

(cherry picked from commit 3ef0562)
@fanny-jiang fanny-jiang mentioned this pull request Jan 7, 2022
Merged
4 tasks
fanny-jiang added a commit that referenced this pull request Jan 8, 2022
@fanny-jiang
Add urllib3 as dependency (#11069) (#11071)
93df3ef 
* add urllib3 as dependency, remove try/catch

* sync deps

* sync licenses

(cherry picked from commit 3ef0562)
@sarah-witt sarah-witt mentioned this pull request May 5, 2022
Merged
4 tasks
@alopezz alopezz mentioned this pull request Jun 16, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhan289 yzhan289 yzhan289 approved these changes

Assignees
No one assigned
Labels
category/bugfix For use during Agent Release period dependencies integration/datadog_checks_base integration/http_check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanny-jiang @yzhan289