run full test suite for every supported Windows SQL Server driver #10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
hithwen
previously approved these changes
Jan 12, 2022
djova
force-pushed
the
djova/sqlserver-windows-test-all-drivers
branch
from
59fe55a to
33c0be0
Compare
Remove the limited "can we connect to SQL Server using all supported drivers?" test in favor of running the full Windows test suite once per supported driver: SQLOLEDB, SQLNCLI11, MSOLEDBSQL, odbc. We've had bugs in the past that are specific to a single driver and this will ensure that all supported drivers are fully tested.
djova
force-pushed
the
djova/sqlserver-windows-test-all-drivers
branch
from
33c0be0 to
1e0a985
Compare
ofek
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the limited "can we connect to SQL Server using all supported drivers?" test in favor of running the full Windows test suite once per supported driver: SQLOLEDB, SQLNCLI11, MSOLEDBSQL, odbc.
We've had bugs in the past that are specific to a single driver and this will ensure that all supported drivers are fully tested.
Also cleanup instance configuration to ensure all instances are derived from the same base "default" instance, which is where we are varying the driver based on the current env.
Motivation
Improve Windows test coverage.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached