Support non-executable files during pipeline setup #10684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a file in the pipeline setup scripts directory starts with an underscore, then it is treated as a "non-executable" file and it will not be executed. This is required for #10637 where a large SQL setup script is needed to be referenced by one of the other scripts, but the SQL script itself must not be executed.
ghost
added
sarah-witt
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Looks good, can you also update the docs here after this PR? https://datadoghq.dev/integrations-core/meta/ci/#scripts
Sure, #10691 |
ChristineTChen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If a file in the pipeline setup scripts directory starts with an underscore, then it is treated as a "non-executable" file and it will not be executed.
This is required for #10637 where a large SQL setup script is needed to be referenced by one of the other scripts, but the SQL script itself must not be executed.
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached